Pattern Inserter: Fix unintended preview panel display when hovering mouse over pattern #47693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mouse over pattern
|
Size Change: +10 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
t-hamano
requested review from
Mamaduka,
youknowriad and
ntsekouras
and removed request for
ellatrix
t-hamano
added
[Feature] Inserter
|
Flaky tests detected in 4f45b41. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4075245693
|
Mamaduka
approved these changes
Feb 2, 2023
Mamaduka
added
the
Backport to Gutenberg RC
|
I just cherry-picked this PR to the release/15.1 branch to get it included in the next release: 5b498c5 |
Mamaduka
removed
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed regression that occurred with #47316
See this comment: #47316 (comment)
What?
This PR fixes a problem where an unintended block preview panel appears behind you when you mouse over any of the patterns from the pattern inserter.
Why?
In #47316, changed to call
onHoverto display the insertion indicator when mouse over a pattern. This updates thehoverdItemstate and causes the preview panel to appear unintentionally in the following locations:gutenberg/packages/block-editor/src/components/inserter/menu.js
Lines 292 to 294 in c9507b0
How?
Added
onHoverPatternseparately fromonHoverto avoid updating thehoveredItem. Ideally, it might be better to control the other condition,showInserterHelpPanel. However, since this property is passed from a upper component, I thought it may be difficult to control using this variable.Testing Instructions
Before
before.mp4
After
after.mp4